stefan-egli commented on code in PR #24:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/24#discussion_r1133644439
##########
src/test/java/org/apache/sling/event/impl/jobs/config/JobManagerConfigurationTestFactory.java:
##########
@@ -52,7 +52,10 @@ public long startup_delay() {
public int cleanup_period() {
return 0;
}
-
+
+ public int progresslog_maxCount() {
+ return 0;
Review Comment:
I was wondering if that was the right default for tests though, I would have
assumed that for tests (that don't focus purely on log) you'd want the previous
behaviour of unlimited logging.
(Have checked for this specific test factory and it's only used by 1 class
currently which doesn't use log - so this change has no influence for now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
