[
https://issues.apache.org/jira/browse/SLING-10107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700150#comment-17700150
]
Timothee Maret commented on SLING-10107:
----------------------------------------
{quote}Merging these into a single commit wouldn't be a problem, and maybe they
even belong together into a single "transaction".
{quote}
Looking at the LocalStore source code, it seems that resolvers are created in
three methods: store, load, and createParent. The three methods are invoked
from different threads, we can't merge them into a single transaction.
> Refactoring of creation of ResourceResolvers
> --------------------------------------------
>
> Key: SLING-10107
> URL: https://issues.apache.org/jira/browse/SLING-10107
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
> Affects Versions: Content Distribution Journal Core 0.1.16
> Reporter: Joerg Hoh
> Priority: Major
>
> In the 2 classes {{Bookkepper}} and the {{Localstore}} the creation of
> ResourceResolvers is spread over multiple places, and also the number of
> methods, where ResourceResolvers are opened for obviously tiny operations is
> quite high.
> Therefor I refactored the creation of ResourceResolvers for the subservice
> bookkeeper (which is the majority of cases) and centralized the creation of
> it into a central supplier within the {{Bookkeeper}}. I also added a new
> Gauge metric to observe how often a new ResourceResolver is actually created.
> My gut feeling is, that the number of creations is (too) high; but before I
> start combining operations and reduce the number of ResourceResolver
> creations, I would like to understand if it's a problem at all.
> See
> https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/63
> for the PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
