stefan-egli commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-event/pull/24#issuecomment-1468140718
Generally looks good to me. Just found 1 subtlety with the way the truncation currently works. It's an edge case, so not necessarily very realistic, but putting it here for completeness : if a log message itself would end with this "... truncated", then that would confuse the current truncation-appending algorithm. Now I'm not sure if we need to support this edge case, leaving that up to you. But what could for example be done is to actually have 1 extra log entry (so it would actually reach max + 1) and store that "... truncated" message only there (where no-one else could write into). Wdyt? But yea, leaving it up to you to decide.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
