andrewmkhoury commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1173913659
##########
src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java:
##########
@@ -84,6 +84,22 @@ public void updateProgress(final long eta) {
}
}
+ @Override
+ public void setProperty(final String name, final Object value) {
+ if ( name == null ) {
+ throw new IllegalArgumentException("Name must not be null");
Review Comment:
Since it is a user facing API, I implemented it opting for
IllegalArgumentException as the exception type. Do you agree or should I
change it and allow it to be an NPE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
