[ 
https://issues.apache.org/jira/browse/SLING-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087667#comment-13087667
 ] 

Bertrand Delacretaz commented on SLING-2185:
--------------------------------------------

Thanks for this Tim, looks good to me!

(note that if you re-upload your patch with the same filename, JIRA does the 
right thing and keeps both versions with dates)

Could you also provide tests for this feature? The simplest might be 
integration tests, you could for example add a few test services under [1] that 
are used by this extension, and add a few tests under [2] that verify that the 
test services are activated. The goal is only to verify that your extension 
does use the supplied services, so you can detect that in any suitable way: for 
example have your test service throw an exception that helps verify that it is 
present, or set something specific in the response that the tests can detect.

We can also discuss this on the sling dev list if you need more details.

[1] http://svn.apache.org/repos/asf/sling/trunk/launchpad/test-services/
[2] http://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/

> Provide a way to configure IOManager/PropertyManager handlers at runtime.
> -------------------------------------------------------------------------
>
>                 Key: SLING-2185
>                 URL: https://issues.apache.org/jira/browse/SLING-2185
>             Project: Sling
>          Issue Type: Improvement
>          Components: JCR
>    Affects Versions: JCR Webdav 2.1.0
>            Reporter: Timothee Maret
>            Priority: Minor
>         Attachments: io-handler-service-reactif.patch, 
> io-handler-service.patch
>
>
> Currently, the handlers for the IOManager and PropertyManager instances are 
> defined in the org.apache.sling.jcr.webdav.impl.helper.SlingResourceConfig 
> class.
> This is not flexible and make it difficult to add project specific handlers 
> in the configuration.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to