> On 4. May 2023, at 09:53, Stefan Seifert <[email protected]> > wrote: > > i've two remarks on this release: > > a) on both modules org.jetbrains:annotations was added with compile scope - > should be provided. although not a problem for the bundle in OSGi runtime, it > should be fixed. i would propose making a new release for it, esp. > considering that the API bundle is released very rarely.
Maybe we can prevent that a config of https://maven.apache.org/enforcer/enforcer-rules/bannedDependencies.html#banned-dependencies in the Sling parent. I think there are potentially more candidates for that (OSGi annotation dependencies). WDYT? > > b) cosmetic: the bnd.bnd. in the event module contains an explicit reference > to sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid > the redundancy and define the actual version only in the POM, otherwise it > might be forgotten to update in in both places in future updates. i think > there are possibilities to express this via expressions. this could be done > in a follow-up release. > > stefan > >> -----Original Message----- >> From: Daniel Klco <[email protected]> >> Sent: Wednesday, May 3, 2023 10:04 PM >> To: [email protected] >> Subject: [VOTE] Release Apache Sling Event API version 1.0.2 and Event >> 4.3.10 >> >> Hi, >> >> We solved 2 issues in this release: >> https://issues.apache.org/jira/projects/SLING/versions/12353195 >> https://issues.apache.org/jira/projects/SLING/versions/12353051 >> >> There are still some outstanding issues: >> https://issues.apache.org/jira/projects/SLING/versions/12344634 >> https://issues.apache.org/jira/projects/SLING/versions/12353196 >> >> Staging repositories: >> https://repository.apache.org/content/repositories/orgapachesling-2740/ >> https://repository.apache.org/content/repositories/orgapachesling-2741/ >> >> You can use this UNIX script to download the release and verify the >> signatures: >> https://gitbox.apache.org/repos/asf?p=sling-tooling- >> release.git;a=blob;f=check_staged_release.sh;hb=HEAD >> >> Usage: >> sh check_staged_release.sh 2740 /tmp/sling-staging sh >> check_staged_release.sh 2741 /tmp/sling-staging >> >> Please vote to approve this release: >> >> [ ] +1 Approve the release >> [ ] 0 Don't care >> [ ] -1 Don't release, because ... >> >> This majority vote is open for at least 72 hours.
