[
https://issues.apache.org/jira/browse/SLING-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720513#comment-17720513
]
Konrad Windszus edited comment on SLING-11864 at 5/8/23 1:48 PM:
-----------------------------------------------------------------
Launchpad configuration (in .config format for PID
{{org.apache.jackrabbit.vault.packaging.impl.PackagingImpl}})
{code}
defaultIdConflictPolicy="LEGACY"
isStrict="false"
overwritePrimaryTypesOfFolders="false"
{code}
In Felix Web Console I edited it the configuration manually to add a new field
{{authIdsForHookExecution}}. Afterwards exporting the config with that PID in
cfg.json format leads to
{code}
{
"defaultIdConflictPolicy":"LEGACY",
"overwritePrimaryTypesOfFolders":false,
"isStrict":false,
"authIdsForHookExecution":[
"sling-distribution-importer"
]
}
{code}
So it contains both the default values as well as the customized ones. IMHO
only config field which differ from the "launchpad" config fields should be
exposed, i.e. I would have expected the following JSON in the configuration
printer:
{code}
{
"authIdsForHookExecution":[
"sling-distribution-importer"
]
}
{code}
was (Author: kwin):
Launchpad configuration (in .config format for PID
{{org.apache.jackrabbit.vault.packaging.impl.PackagingImpl}})
{code}
defaultIdConflictPolicy="LEGACY"
isStrict="false"
overwritePrimaryTypesOfFolders="false"
{code}
In Felix Web Console I edited it the configuration manually to add a new field
{{authIdsForHookExecution}}. Afterwards exporting the config with that PID in
cfg.json format leads to
{code}
{
"defaultIdConflictPolicy":"LEGACY",
"overwritePrimaryTypesOfFolders":false,
"isStrict":false,
"authIdsForHookExecution":[
"sling-distribution-importer"
]
}
{code}
So it contains both the default values as well as the customized ones. IMHO
only config field which differ from the "launchpad" config fields should be
exposed.
> Configuration merge not considered in OSGi Installer Configuration Printer
> Web Console
> --------------------------------------------------------------------------------------
>
> Key: SLING-11864
> URL: https://issues.apache.org/jira/browse/SLING-11864
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Configuration Factory 1.4.2
> Reporter: Konrad Windszus
> Priority: Major
>
> Despite
> https://sling.apache.org/documentation/bundles/configuration-installer-factory.html#merging-of-configurations
> stating that
> bq. Similar, for write back and the OSGi Installer Configuration Printer Web
> Console only the properties with different configuration values than the
> default configuration are written back/exposed.
> I still see all values which differ from the metatype default value being
> exposed at {{/system/console/osgi-installer-config-printer}}. I tried with a
> distribution which has two configurations
> {code}
> * org.apache.jackrabbit.vault.packaging.impl.PackagingImpl:
> 2a425da9bfe3907800abf828d7dba911/200,
> jcrinstall:/apps/system/config/org.apache.jackrabbit.vault.packaging.impl.PackagingImpl.cfg.json,
> INSTALLED,
> - 311121c892dc31cecae4b5844a5855e9/50,
> launchpad:resources/config/org.apache.jackrabbit.vault.packaging.impl.PackagingImpl.config,
> INSTALL, Another resource with the same entity id but a higher version or
> priority or digest found (in that order, the latter only in case the version
> is a SNAPSHOT)!
> {code}
> and framework property {{sling.installer.config.mergeSchemes = launchpad}}.
> Still values from both sources are exposed at
> {{/system/console/osgi-installer-config-printer?pid=org.apache.jackrabbit.vault.packaging.impl.PackagingImpl&format=JSON}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
