rombert commented on PR #168: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/168#issuecomment-1538527123
> So your proposal is to keep generating invalid XMLs unless user opted in to fail in that case? You can call it that way, yes. You can also formulate it as "we are releasing a minor version of the cp converter that might break existing projects, because of a refactoring". Given that our toolchain worked before, I think this is a drastic move and should be reconsidered. > I see a need to break here as generating invalid XML (with undeclared prefixes) may easily trigger follow-up issues which are close to impossible to detect then. I'm not sure I follow. I think we are in one of the two scenarios: | Namespace present in Initial-Content file | Namespace declared in Repository | Outcome | | ------------- | ------------- |------------- | | No | Yes | Installation proceeds, based on the repository namespace mapping | | No | No | Installation is halted | What we are doing is changing the outcome of the first scenario. Since no one actually complained about the lenient namespace handling and this only came up after a refactoring I am confident this was not a real problem to solve. That is not to say the refactoring was not valuable, I am very glad that it was done, but we should not introduce such behaviour changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
