stefanseifert commented on code in PR #20:
URL:
https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/20#discussion_r1190251142
##########
src/main/java/org/apache/sling/testing/mock/jcr/MockAuthorizable.java:
##########
@@ -67,7 +66,7 @@ abstract class MockAuthorizable implements Authorizable {
intermediatePath = "/home/users"; // NOSONAR
}
}
- this.path = Paths.get(intermediatePath, this.id).toString();
+ this.path = intermediatePath + "/" + this.id;
Review Comment:
yes, this would be better. the class you mention is not available in the
classpath.
i assume it's part of `org.apache.jackrabbit:oak-commons`. we could add it,
but then we would need to manage the version of this dependency in all contexts
as well fitting to the actual oak version used.
so it would be better to find a better methods in the dependencies we
already have in place to not over-complicate things here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
