[
https://issues.apache.org/jira/browse/SLING-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-11866.
-------------------------------------
Resolution: Invalid
As clarified in SLING-10771 the merged configurations are orthogonal and not
supposed to be filtered in this SPI.
> WebconsoleConfigurationHandler does not filter out default values coming from
> ConfigTaskCreator.getDefaultProperties
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-11866
> URL: https://issues.apache.org/jira/browse/SLING-11866
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Configuration Factory 1.4.2
> Reporter: Konrad Windszus
> Priority: Major
>
> Although {{MetatypeHandler.updateConfiguration}} takes the default
> configurations identified via {{ConfigTaskCreator.getDefaultProperties(...)}}
> as fourth argument it will never strip those properties from the props to
> update. Therefore {{WebconsoleConfigurationHandler.updateConfiguration(...)}}
> will only ever strip properties which have
> a) a default which is equal to the value to be set and
> b) which are not contained in {{ConfigTaskCreator.getDefaultProperties(...)}}
> b) just seem to be wrong as the logic should rather be:
> strip all properties whose value is either equal to the metatype default
> value or the default value coming from the same named property of the the
> configuration provided by any of the MERGE_SCHEME configs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)