Hi, On Fri, 2023-05-12 at 14:24 +0200, Konrad Windszus wrote: > Hi, > Currently we still build by default all our modules with Java 8 on > Linux only [1]. > In SLING-11843 I proposed to change the default to Java 11 and 17 > with Linux and Windows. > The default build (i.e. the one which deploys the Snapshot) would be > Java 11 on Linux. > > As there were some concerns raised that multiple builds may break due > to this change I would like to hear if there are any objections to > raise the default CI build in the proposed way. > In my opinion every maintained Sling module should build nowadays > with Java 11 and 17 on both Linux and Windows (to ease > contributions).
Overall I think this is a very good idea. We will make it simpler for new contributors. I don't think people usually have Java 8 installed and not everyone is on Linux (yet ;-) ). The concern I raised was on making it hard to fix a module because we introduce multiple changes - Java 8 → Java 11, Java 17 - Linux → Linux, Windows That will make it more difficult to get the module building again. I am not _that_ worried about Windows, I am more thinking about the need to update the parent POM to >= 35 for Java 11, which brings the migration to bnd and to the official OSGi annotations. If I'm the only one concerned, then we should not spend more time talking about it and "just do it" instead :-) It would be good to send a notification when the merge happens, so maintainers can check which modules are affected. Is a Jenkins rebuild going to happen once the https://github.com/apache/sling-tooling-jenkins/pull/16 is merged or will the potential failures be exposed once a new CI job runs? Thanks, Robert > All other failing modules either need to be fixes accordingly or > deprecated. > > Thanks in advance for your opinions, > Konrad > > > [1] - > https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues > [2] - https://issues.apache.org/jira/browse/SLING-11843
