kwin commented on code in PR #9:
URL:
https://github.com/apache/sling-org-apache-sling-security/pull/9#discussion_r1194344743
##########
src/main/java/org/apache/sling/security/impl/ReferrerFilter.java:
##########
@@ -260,16 +264,32 @@ private Pattern[] createRegexPatterns(final String[]
regexps) {
return patterns.toArray(new Pattern[0]);
}
+ private String[] mergeValues(String[] primary,
List<ReferrerFilterAmendment> amendments,
Review Comment:
why not returning a collection here? IIUC it is later on anyways converted
to a list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
