[ 
https://issues.apache.org/jira/browse/SLING-11767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723001#comment-17723001
 ] 

Kyle Giovannetti commented on SLING-11767:
------------------------------------------

There might be value in clarifying the descriptions used for the configuration:
{noformat}
Enable XML
Whether the renderer for XML of the default GET servlet is enabled or 
not.{noformat}
I can see how someone might think that by unchecking this option that they have 
actually disabled the XML renderer - when all they have really done is disable 
the default extension -> renderer mapping. 

I think changing the wording would clear up the confusion and would be a 
non-breaking change. 

Other options to prevent any confusion would be to get rid of the checkboxes 
entirely and require the aliases to be configured even for the default 
mappings. 
Or, each of the renderers could have a multifield of all the extensions that 
would be mapped to that renderer, and the renderer would only be created of the 
list length > 0. 

 

kyle

> Disabled XML renderer is still used when configured in extension alias
> ----------------------------------------------------------------------
>
>                 Key: SLING-11767
>                 URL: https://issues.apache.org/jira/browse/SLING-11767
>             Project: Sling
>          Issue Type: Bug
>          Components: Servlets
>    Affects Versions: Servlets Get 2.1.44
>            Reporter: Bjoern Weide
>            Priority: Major
>
> When configuring an extension alias ("aliases") in the Sling Get servlet as
> {code:java}
> xml:pdf {code}
> that maps the pdf extension to the xml extension the content is rendered 
> using the XML renderer, even when the XML renderer is disabled (via 
> "enable.xml" = false).
> This can be reproduced via Sling 12 starter using
> {code:java}
> curl http://admin:admin@localhost:8080/content/starter.pdf{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to