enapps-enorman commented on PR #22:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/22#issuecomment-1569439559
> @enapps-enorman The leading colon properties in import json are not
ignored and result in a "invalid property name" exception. My idea was to make
sense of them instead of failing.
>
I understand. I guess I was thinking of how the default sling POST servlet
collects the content to be written to the repository.
```
SlingPostConstants.RP_PREFIX - "... This prefix must be used on all request
parameters which have significance to POST request processing. Such
parameters will not be used to denote properties to be written to the
repository."
```
> The Data URL style syntax is fine, but it is meant to embed small data
inline. Not sure if JCR binaries will fit into it.
I'm not sure how this is different from your other proposal. The base64
encoded text would be the same length with either syntax.
> I'm working on a symmetrical PR to Sling GET Servlet to write the binary
data, and would like to propose the leading colon syntax for a start. I'm fine
to change it, but both parties need to agree.
I understand, but I would expect that including base64 encoded binaries in
the json output should be optional (and disabled by default) as it could be
abused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
