enapps-enorman commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/11#issuecomment-1572335408
I'm still a bit concerned about this being a vector toward a denial-of-service attack. For example, consider a scenario with a just a few large files in a folder. A swarm of "resource.withBinaries.json" requests to render that folder would load the base64 strings for all those files into memory which could exhaust all the server side memory. Perhaps refactoring the JsonRenderer implementation to use javax.json.stream.JsonGenerator more directly to write the JSON data in a streaming way could mitigate that risk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
