cziegeler commented on code in PR #89:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/89#discussion_r1214088620
##########
src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java:
##########
@@ -163,15 +163,27 @@
@AttributeDefinition(name = "Allowed Vanity Path Location",
description ="This setting can contain a list of path prefixes, e.g.
/libs/, /content/. If " +
"such a list is configured, only vanity paths from
resources starting with this prefix " +
- " are considered. If the list is empty, all vanity paths
are used.")
+ " are considered. If the list is empty, we fallback to
resource.resolver.vanitypath.allowlist.")
Review Comment:
I think the fallback should be in the opposite direction: if the new
property is not used, the old one will be used
##########
src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryConfig.java:
##########
@@ -163,15 +163,27 @@
@AttributeDefinition(name = "Allowed Vanity Path Location",
description ="This setting can contain a list of path prefixes, e.g.
/libs/, /content/. If " +
"such a list is configured, only vanity paths from
resources starting with this prefix " +
- " are considered. If the list is empty, all vanity paths
are used.")
+ " are considered. If the list is empty, we fallback to
resource.resolver.vanitypath.allowlist.")
String[] resource_resolver_vanitypath_whitelist();
+ @AttributeDefinition(name = "Allowed Vanity Path Location",
+ description ="This setting can contain a list of path prefixes, e.g.
/libs/, /content/. If " +
+ "such a list is configured, only vanity paths from resources
starting with this prefix " +
+ " are considered. If the list is empty, all vanity paths are
used.")
+ String[] resource_resolver_vanitypath_allowlist();
+
@AttributeDefinition(name = "Denied Vanity Path Location",
description ="This setting can contain a list of path prefixes, e.g.
/misc/. If " +
"such a list is configured,vanity paths from resources
starting with this prefix " +
- " are not considered. If the list is empty, all vanity
paths are used.")
+ " are not considered. If the list is empty, we fallback to
resource.resolver.vanitypath.denylist.")
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
