Hi Robert,

What issue are we trying to solve here? Is this only about preventing someone 
to press the merge button in the GitHub UI too soon?
Did that happen in the past?

Too me this right now sounds a bit like over engineering, as the proposed 
mandatory checks are not always easy to pass (sometimes even impossible).
So there must be a way to override those rules. 
Is the information provided by the status checks not enough for every 
responsible Sling committer to decide whether to merge or not?

Or is this really only about auto-merge?
I have the feeling I kind of missed the point of the proposal, maybe you can 
elaborate a bit more.

Thanks,
Konrad

> On 5. Jun 2023, at 16:49, Robert Munteanu <[email protected]> wrote:
> 
> Hi,
> 
> I have drafted a proposal about enforcing CI checks for pull requests
> [1]. I don't consider it fully ready as it includes a section of
> classifying the Sling modules which is going to need more attention.
> 
> I'd welcome early feedback nevertheless, to check whether this looks
> like the direction in which we should be heading.
> 
> Thanks for your inputs,
> Robert
> 
> [1]:
> https://cwiki.apache.org/confluence/display/SLING/Enforcing+CI+checks+for+pull+requests

Reply via email to