stefanseifert commented on code in PR #34:
URL:
https://github.com/apache/sling-org-apache-sling-xss/pull/34#discussion_r1250980079
##########
pom.xml:
##########
@@ -172,6 +172,33 @@
</includes>
</configuration>
</plugin>
+ <!-- Shade 3rdparty libs to avoid classpath conflicts in unit
tests -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <configuration>
+ <artifactSet>
+ <includes>
+ <include>com.google.guava:*</include>
+ </includes>
+ </artifactSet>
+ <createSourcesJar>true</createSourcesJar>
+ <relocations>
+ <relocation>
+ <pattern>com.google.common</pattern>
+
<shadedPattern>sling-xss.com.google.common</shadedPattern>
Review Comment:
i stumbled over this as well when taking over the configuration from sling
models impl bundle - it seems to work fine there, and i deployed this bundle in
a local instance and it seems to work there as well. but we can also easily
remove the dash here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
