Hi, On Fri, 2023-07-07 at 15:04 +0000, Stefan Seifert wrote: > hello konrad. > > yes, that's an important open issue. the ideal solution would be a) > switch to sling 12 + integrate the integration tests in the models > impl repository, and have them automatically executed in jenkins when > models impl change.
Right, I think having the tests together with the code makes many things simpler. > > this probably involves splitting the integration tests in two parts > and putting the exporter-related integration tests into the > jacksonexporter repository. > > but that's a good deal of work to get this running. i'm lacking the > knowledge in the feature model tooling to get a good start on this. I found [1], in case anyone wants to give the conversion a shot. Thanks, Robert [1]: https://sling.apache.org/documentation/feature-model/howtos/create-sling-fm.html > > stefan > > > -----Original Message----- > > From: Konrad Windszus <[email protected]> > > Sent: Friday, July 7, 2023 4:57 PM > > To: [email protected] > > Subject: Sling Models Integration Tests broken > > > > HI, > > The ITs at https://github.com/apache/sling-org-apache-sling-models- > > integration-tests built through https://ci- > > builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fslin > > g-org- > > apache-sling-models-integration-tests/activity are failing since > > quite > > some time and also reference pretty outdated Sling Models bundle > > versions. > > Seems that the root issue is that even that outdated version of > > Models > > Impl (1.5.3-SNAPSHOT, > > https://github.com/apache/sling-org-apache-sling- > > models-integration- > > tests/blob/3a20ea6b8e2cd025e396797be94b8268a240efae/pom.xml#L261C30 > > - > > L261C30) requires a newer version of Sling API than shipped with > > Sling > > Starter 11: > > > > "06.07.2023 18:29:43.869 *INFO* [OsgiInstallerImpl] > > org.apache.sling.installer.core.impl.tasks.BundleStartTask Could > > not start > > bundle org.apache.sling.models.impl [147]. Reason: {}. Will retry. > > org.osgi.framework.BundleException: Unable to resolve > > org.apache.sling.models.impl [147](R 147.0): missing requirement > > [org.apache.sling.models.impl [147](R 147.0)] osgi.wiring.package; > > (&(osgi.wiring.package=org.apache.sling.api.resource)(version>=2.12 > > .0)(!(v > > ersion>=3.0.0))) Unresolved requirements: > > [[org.apache.sling.models.impl > > [147](R 147.0)] osgi.wiring.package; > > (&(osgi.wiring.package=org.apache.sling.api.resource)(version>=2.12 > > .0)(!(v > > ersion>=3.0.0)))]” > > > > Two options come to my mind: > > a) Switch IT to Sling Starter 12 (requires some effort due to the > > change > > from the Sling Provisioning Model to the OSGi Feature Model) > > b) Tweak Starter 11 with newer versions of particular bundles > > required for > > Sling Models > > > > We probably need to pay more attention that at least before > > releasing > > Sling Models the ITs are executed successfully. I admit though that > > due to > > the distributed nature of the repositories I often forget about > > those > > myself. Any hints how to make the linking between API, > > Implementation and > > IT repos more prominent? > > > > Thanks, > > Konrad
