[
https://issues.apache.org/jira/browse/SLING-11922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741980#comment-17741980
]
Robert Munteanu commented on SLING-11922:
-----------------------------------------
I think we need to pull in the code from GitHub. Looking at the processed
feature model versions from {{target/slingfeature-tmp}} I see two main problems:
- the folder structure is not preserved
- the "txt" repoinit files are inlined
This makes the files less useful.
The archetype, when running, can do the following
- download
https://github.com/apache/sling-org-apache-sling-starter/archive/refs/heads/master.zip
- extract all files from under src/main/features ( configurable skip list: HTL
repl and Slingshot )
- read pom.xml copy over all "*.version" properties to the launcher pom
- generate the "app.json" feature under src/main/features/app
> Create a fully expanded feature model when generating the archetype
> -------------------------------------------------------------------
>
> Key: SLING-11922
> URL: https://issues.apache.org/jira/browse/SLING-11922
> Project: Sling
> Issue Type: Improvement
> Components: Maven Plugins and Archetypes
> Reporter: Robert Munteanu
> Assignee: Robert Munteanu
> Priority: Major
> Fix For: Project Archetype 1.0.10
>
>
> Implement
> https://cwiki.apache.org/confluence/display/SLING/Enhance+the+Project+Archetype+to+provide+a+fully+expanded+feature+model
> Some finer points to consider:
> - should we pull in all code from GitHub/master? We probably need the "raw"
> versions, not the ones processed already processed and deployed
> - should we include the latest released version (13) in the repo for offline
> execution fallback?
> - need to handle pom-defined versions somehow, so we can't "just" copy over
> the files
> - since we already generate our own app in the archetype, we should not
> include slingshot. The HTL repl is probably a bit dangerous to include
> - the starter content bundle should also be removed, but we should look out
> for SLING-10605, SLING-10606
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
