jsedding commented on code in PR #103:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/103#discussion_r1324348613
##########
src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverMetrics.java:
##########
@@ -77,11 +77,11 @@ public class ResourceResolverMetrics {
private ServiceRegistration<Gauge<Long>>
numberOfVanityPathBloomFalsePositiveGauge;
private Supplier<Long> numberOfVanityPathBloomFalsePositiveSupplier =
ZERO_SUPPLIER;
- // number of aliases
- private ServiceRegistration<Gauge<Long>> numberOfAliasesGauge;
- private Supplier<Long> numberOfAliasesSupplier = ZERO_SUPPLIER;
+ // number of resources with aliased children
+ private ServiceRegistration<Gauge<Long>>
numberOfResourcesWithAliasedChildrenGauge;
+ private Supplier<Long> numberOfResourcesWithAliasedChildrenSupplier =
ZERO_SUPPLIER;
Review Comment:
Not really this PR, just related: I think all `Supplier` fields need to be
volatile. It looks like they can be updated at any moment. Am I missing
something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
