bdelacretaz commented on code in PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1329745936
########## src/main/java/org/apache/sling/jcr/base/internal/AllowListFragment.java: ########## @@ -32,59 +32,58 @@ import static java.util.Arrays.asList; @ObjectClassDefinition( - name = "Apache Sling Login Admin Whitelist Configuration Fragment", - description = "Whitelist configuration fragments contribute a list of whitelisted bundle symbolic " + - "names to the Login Admin Whitelist. This allows for modularisation of the whitelist." + name = "Apache Sling Login Admin Allow List Configuration Fragment", + description = "Allow list configuration fragments contribute a list of allow listed bundle symbolic " + Review Comment: I think rewording the description would make it easier to understand, just replacing "white list" with "allow list" makes it hard to read IMHO, I suggest: > This list of Bundle Symbolic Names is added to the list of bundles which are allowed to use Administrative Login. The full list is built, in a modular way, out of all such configuration fragments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
