stefanseifert commented on code in PR #19:
URL:
https://github.com/apache/sling-tooling-jenkins/pull/19#discussion_r1358063124
##########
vars/slingOsgiBundleBuild.groovy:
##########
@@ -189,6 +189,8 @@ def defineStage(def globalConfig, def jobConfig, def
jdkVersion, def operatingSy
}
// calculate coverage with jacoco (for subsequent evaluation by
SonarQube)
additionalMavenParams = "${additionalMavenParams} -Pjacoco-report"
+ // generate javadocs to detect illegal javadoc markup in sources
+ additionalMavenParams = "javadoc:javadoc ${additionalMavenParams}"
Review Comment:
i thought about this as well, but the variable goal is used in other placed
to distinguish between different code paths, and i do not wanted to meddle with
this as it might lead to unexpected results if more conditions like this are
added later.
the current solution mixing in the additional goal in the
additionalMavenParams is also not optimal, but should have not sideffects.
maybe the whole script should be refactored a bit to make it easier to
inject additional goals without risking the condition checks based on the
primary goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
