jsedding commented on PR #44:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/44#issuecomment-1778682001
**Update:**
Yesterday evening I wrote a unit test around the repoinit snippet below,
making sure the repository is initialized with the validator for
`rep:externalId`. I'll contribute this test today via a separate PR.
It turns out that I was wrong (my manual tests must have been incorrect) and
this snippet works (test passes). I even went back to
org.apache.sling.jcr.repoinit-1.1.38 and the test also passes.
```
create group fooBar
set properties on authorizable(fooBar)
set rep:externalId to "fooBar;ldap"
end
```
Subsequently, I repeated my manual tests twice and they also passed.
Now the question is whether this change should be reverted? I still consider
it a valuable change/fix that better aligns the implementation with implicit
expectations of the users of repoinit. WDYT @anchela, @kwin ?
@kwin I saw your comment regarding documentation and will add a paragraph if
we decide to keep this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
