rmcdouga commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1797023577
There's a serious issue in the MapUtils code. The code tries to handle a Dictionary object but does so poorly (generates a StackOverflow error). Now it turns out this wasn't caught before because Dictionary is an abstract class with only one subclass in the JDK (HashTable). HashTable implements Map, so Hashtables don't ever make it down to the Dictionary-specific code. The only code that will make it down there is a custom subclass of Dictionary. Given how old and unused Dictionary is (it was replaced by Map in JDK 1.2), I think it's safe to remove the section of code that tries (unsuccessfully) to deal with Dictionary subclasses, but I would like to verify that this is OK with a committer before I do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
