[
https://issues.apache.org/jira/browse/SLING-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783402#comment-17783402
]
Rob McDougall commented on SLING-12130:
---------------------------------------
So, I went ahead and fixed it, but I am running across a code coverage issue
with SonarCube. There's some code I didn't write but that I modified (added
types to an untyped Generic). This particular class didn't have good code
coverage to begin with but, being keen, I added tests. The problem is the new
test code uncovered a problem with the previously untested code.
The code pertains to an if statement that tries to handle the case where the
object passed in is a Map or a Dictionary object. The Map code works just
fine, but the Dictionary code creates a Stack Overflow error. I'd like to just
remove it. Dictionary is old and its only subclass is HashTable (which
implements Map), so the only use case we lose is if someone has a custom class
the derives from Dictionary but does not implement Map.
Given how old Dictionary is, I would like to just remove that code and not
handle that case. Strictly speaking this is a breaking change however it seems
like quite a remote possibility that any code would, in practice, actually
break.
Before I do that however, I'd like to get the OK to make that change.
> Update Apache Sling Hamcrest Matchers to use latest version of Hamcrest
> libraries
> ---------------------------------------------------------------------------------
>
> Key: SLING-12130
> URL: https://issues.apache.org/jira/browse/SLING-12130
> Project: Sling
> Issue Type: Task
> Reporter: Rob McDougall
> Priority: Major
> Fix For: Testing Hamcrest 1.0.4
>
>
> The Apache Sling Hamcrest Matchers use hamcrest-library 1.3
> ([here|[https://github.com/apache/sling-org-apache-sling-testing-hamcrest/blob/master/pom.xml]).]
> This version is circa 2012. The latest (2.2) is from 2019 ([as shown
> here|[https://central.sonatype.com/artifact/org.hamcrest/hamcrest-core/versions]).]
>
> Is it OK if I make a PR to update to the latest version?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
