[ 
https://issues.apache.org/jira/browse/SLING-12133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-12133.
--------------------------------------
    Resolution: Fixed

Solved it a little bit different in 
https://github.com/apache/sling-org-apache-sling-engine/commit/6b0675f0a8700afc9829118508eedb30f2fe75b9

A preprocessor just records the start time which then is later picked up by the 
current filter as the real start time instead of "now". This change should have 
the least impact on any existing code

> Include time spend in authentication in request log
> ---------------------------------------------------
>
>                 Key: SLING-12133
>                 URL: https://issues.apache.org/jira/browse/SLING-12133
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>            Priority: Major
>             Fix For: Engine 2.15.8
>
>
> The request logging is currently triggered by a servlet filter. Filters run 
> after authentication and therefore the time spent in authentication is not 
> included. In addition time spent in anything before authentication (like 
> preprocessors) is not included either.
> We should change RequestLoggerFilter from a filter to an early running 
> Preprocessor. However,currently the RequestLoggerFilter has two purposes - 
> one is the logging and the other one is preparing request and response 
> objects. We need to split that functionality and keep it in the filter - 
> Preprocessors run for every http context, not just Sling so we need to avoid 
> that this code runs outside of Sling's context.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to