stefanseifert commented on PR #31:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/31#issuecomment-1809987488
thanks for this PR! some comments:
* updating the testing dependencies junit and and mockito is an non-brainer
and should be done immediately
* however, we should keep those testing deps in all the mocks and we
should update it also in osgi-mock, jcr-mock, resourceresolver-mock - but this
is separate form this PR
* it's also a good thing that we can finally get rid of commons-lang 2 (it
was still there because former dependencies required it, but it's no longer the
case)
* for updating the other dependencies it's always a balancing act:
sling-mock is used in a lot of projects, and most of them do not have the
luxury to always use the latest dependencies from everything. in fact, it's
used a lot in downstream products as AEM and i try to keep compatibility for
the versions still in use. in those cases, the dependencies that are actually
used in the test run are not determined by the POM here, but but the
dependencies defined in the project and target environment, e.g. using the ways
described here: https://wcm.io/testing/aem-mock/usage-maven-dependencies.html
* so in sling-mock, i usually keep the dependencies older and only update in
a bunch every 1-2 years with a focus on maximum compatibility (last time in
[SLING-11295](https://issues.apache.org/jira/browse/SLING-11295)).
* if we update those 3rparty deps (or sling deps) too early, we risk that
new features are used in the code of sling-mock itself, and that breaks the
tests if used in older environment's projects
best thing would be to split up this PR in one only affecting the testing
dependencies, probably one for removing commons-lang 2. i'm not sure if there
is benefit in updating the other 3rdparty dependencies currently
(commons-lang3 is used in version 3.9 as inherited form osgi-mock). i also keep
those 3dparty deps in sync across all mocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
