jsedding commented on code in PR #20:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/20#discussion_r1394490078
##########
pom.xml:
##########
@@ -34,12 +34,10 @@
<description>Runs JUnit tests in an OSGi framework and provides the JUnit
libraries</description>
<properties>
- <junit.version>4.13</junit.version>
+ <junit.version>4.13.2</junit.version>
<hamcrest.version>1.3</hamcrest.version>
<jacoco.version>0.6.2.201302030002</jacoco.version>
- <junit-jupiter.version>5.6.0</junit-jupiter.version>
- <maven.compiler.source>1.8</maven.compiler.source>
- <maven.compiler.target>1.8</maven.compiler.target>
+ <junit-jupiter.version>5.10.0</junit-jupiter.version>
Review Comment:
We could bump it to 5.10.1 already.
##########
src/it/annotations-it/pom.xml:
##########
@@ -29,7 +29,6 @@
<properties>
- <sling.java.version>8</sling.java.version>
Review Comment:
Do we need to drop java 8 support for technical reasons? Otherwise, I would
be inclined to keep it.
##########
pom.xml:
##########
@@ -296,7 +313,7 @@
<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-launcher</artifactId>
- <version>1.6.2</version>
+ <version>1.10.0</version>
Review Comment:
1.10.1 is already available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
