stefanseifert commented on code in PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-fsresource/pull/2#discussion_r1396971761
##########
pom.xml:
##########
@@ -199,7 +199,8 @@
<dependency>
<groupId>org.apache.johnzon</groupId>
<artifactId>johnzon-core</artifactId>
- <version>1.1.1</version>
+ <classifier>jakarta</classifier>
Review Comment:
i think this is not a way we ca go here. we ship johnzon in sling starter as
part of this wrapper bundle:
https://github.com/apache/sling-org-apache-sling-commons-johnzon - and this
contains only the non-jakarta version. and we cannot just add the jakarta
version as well as we cannot export two different variants of the same code
with the same version number via OSGi.
i think the correct way would be to switch to Johnzon 2.0 (see
https://johnzon.apache.org/download.html, it seems to be already released
although the documentation page is not updated yet). however, to do this we
would need to prepare a new version of the johnzon wrapper bundle first
including the 2.0 version range.
and i assume that for a longer time we need to support both 1.x and 2.x
johnzon version range, as we have a lot of modules out there relying on 1.x and
the javax.json packages.
maybe we should start a discussion on this on the mailing list.
##########
.sling-module.json:
##########
@@ -0,0 +1,6 @@
+{
Review Comment:
we should deviate from the default build environments for all sling modules
only with a good reason - why do you exclude windows here, and limit the jdks
to 11 and 17?
if there is an issue with the build an windows, we should fix the root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
