kwin commented on PR #107: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/107#issuecomment-1824555606
> Regarding the "easier to understand" part, I believe that the current implementation, as well as yours, suffer from an underspecification of the ordering of aliases defined on a resource and on its jcr:content child. I.e. assume we have /foo/sling:alias=bar and /foo/jcr:content/sling:alias=baz. Which one would be "first"? IIUC, currently it depends on which one is inserted first. The logic has not changed so therefore I consider this argument orthogonal to the actual issue being fixed here. Feel free to create a dedicated issue to get some clarification or come up with a use case where this impl behaves different than before. > I would much rather hide the implementation details, especially in the signatures We can evolve after applying this fix. It is deliberately not doing refactoring to be easier to review. But let me revert to using the most generic interfaces for now which is `Map<Map<String,Collection<String>>` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
