I find it very strange to base a -1 on these minor issues


On 07.12.2023 10:39, Konrad Windszus wrote:
Hi,
-1 from my side because the manifest does not contain the necessary 
"Provide-Capability: osgi.contract;osgi.contract=JavaJSONP".
Probably a regression in Johnzon itself.

Also the readme should be clarified that this implements JSON-P 2.1.1.
As Johnzon now requires Java 11 
(https://issues.apache.org/jira/browse/JOHNZON-393) we can also generate Java 
11 byte code in our wrapper 
(https://github.com/apache/sling-org-apache-sling-commons-johnzon/blob/f86b63f3db139f2ae0711cd8700c896affeaf9b1/pom.xml#L29)

The master branch looks incorrect now: It has version 2.0.0 instead of 
2.0.1-SNAPSHOT.
Did something go wrong with the release?
Konrad



On 6. Dec 2023, at 20:39, Carsten Ziegeler <[email protected]> wrote:

Hi,

We solved 1 issue in this release
https://issues.apache.org/jira/browse/SLING-12182

Staging repository: 
https://repository.apache.org/content/repositories/orgapachesling-2819/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2819 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
--
Carsten Ziegeler
Adobe
[email protected]


--
Carsten Ziegeler
Adobe
[email protected]

Reply via email to