stefanseifert commented on PR #48:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/48#issuecomment-1851880092
i skimmed through the reformattings, some remarks:
* a lot of lines are reformatted into two or multiple lines because they
seem to exceed a configured line lenght limit by a few chars. not sure what the
configured values is, i have the feeling that with big screens available for
most we should not limit this too much. and not the same limit is applied
everywhere, e.g. comments behind `//` are reformatted wheres comments within
`/* ... */`are not.
* log statements are reformatted to something like
```
log.warn(
"Unable to register model class {} because adapter
class {} is not valid.",
clazz.getName(),
adapterClass.getName());
```
* i prefer putting `else {` after `}` on a new line instead of `} else {`
* i would not put a space after a casting expresssion as in
`setConstructorParameter((ConstructorParameter) element, parameterValues,
value)`
all of this points are matter of taste, of course. not sure if we want to
finetune all those details or accept it as-is. it will be difficult to find a
common sense anyway on lot of those points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
