cziegeler commented on code in PR #149: URL: https://github.com/apache/sling-site/pull/149#discussion_r1431173638
########## src/main/jbake/content/documentation/development/dependency-management.md: ########## @@ -39,28 +38,21 @@ The parent POM only does dependency management for build time dependencies and a The `<dependencyManagement>` element currently contains the following managed dependencies: -| Group ID | Artifact ID | Version | Scope | -|---|---|---|---| -| org.osgi | org.osgi.core | 4.1.0 | provided | -| org.osgi | org.osgi.compendium | 4.1.0 | provided | -| javax.servlet | servlet-api | 2.4 | provided | -| javax.jcr | jcr | 1.0 | provided | -| org.slf4j | slf4j-api | 1.5.2 | provided | -| org.apache.felix | org.apache.felix.scr.annotations | 1.9.8 | provided | -| biz.aQute | bndlib | 1.50.0 | provided | -| junit | junit | 4.11 | test | -| org.jmock | jmock-junit4 | 2.5.1 | test | -| org.slf4j | slf4j-simple | 1.5.2 | test | +* OSGi spec chapter dependencies (in sling-bundle-parent) +* Some testing libraries (like JUnit) +* Some common JSRs (Servlet, JCR, JSR-330) +* SLF4J +For details refer to the `pom.xml` of [sling-bundle-parent](https://github.com/apache/sling-parent/blob/master/sling-bundle-parent/pom.xml) and [sling](https://github.com/apache/sling-parent/blob/master/sling-parent/pom.xml). Review Comment: These changes look good ########## src/main/jbake/content/documentation/development/dependency-management.md: ########## @@ -39,28 +38,21 @@ The parent POM only does dependency management for build time dependencies and a The `<dependencyManagement>` element currently contains the following managed dependencies: -| Group ID | Artifact ID | Version | Scope | -|---|---|---|---| -| org.osgi | org.osgi.core | 4.1.0 | provided | -| org.osgi | org.osgi.compendium | 4.1.0 | provided | -| javax.servlet | servlet-api | 2.4 | provided | -| javax.jcr | jcr | 1.0 | provided | -| org.slf4j | slf4j-api | 1.5.2 | provided | -| org.apache.felix | org.apache.felix.scr.annotations | 1.9.8 | provided | -| biz.aQute | bndlib | 1.50.0 | provided | -| junit | junit | 4.11 | test | -| org.jmock | jmock-junit4 | 2.5.1 | test | -| org.slf4j | slf4j-simple | 1.5.2 | test | +* OSGi spec chapter dependencies (in sling-bundle-parent) +* Some testing libraries (like JUnit) +* Some common JSRs (Servlet, JCR, JSR-330) +* SLF4J +For details refer to the `pom.xml` of [sling-bundle-parent](https://github.com/apache/sling-parent/blob/master/sling-bundle-parent/pom.xml) and [sling](https://github.com/apache/sling-parent/blob/master/sling-parent/pom.xml). All dependencies per module are fully described in terms of version, scope, and classifier by the respective project. -The version of the module dependency should be selected according to the following rule: The lowest version providing the functionality required by the module (or bundle). By required functionality we bascially mean provided API. +The version of the module dependency should be selected according to the following rule: **The lowest version providing the functionality required by the module (or bundle)**. By required functionality we basically mean provided API. Review Comment: This change looks good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
