joerghoh commented on code in PR #108:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/108#discussion_r1432806575
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -1288,50 +1288,60 @@ private Iterator<Resource> queryAllVanityPaths(String
query) {
return it;
}
+ /**
+ * Utility class for running paged queries.
+ */
private class PagedQueryIterator implements Iterator<Resource> {
private ResourceResolver resolver;
+ private String name;
+ private String propertyName;
private String query;
- private String lastPath = "";
+ private String lastValue = "";
private Iterator<Resource> it;
private int count = 0;
private int page = 0;
- private int pageSize = Integer.getInteger("sling.vanityPath.pageSize",
2000);
+ private int pageSize;
private Resource next = null;
+ private String[] defaultValue = new String[0];
- public PagedQueryIterator(ResourceResolver resolver, String query) {
+ public PagedQueryIterator(String name, String propertyName,
ResourceResolver resolver, String query, int pageSize) {
Review Comment:
```name``` is quite generic. If we don't come up with a better name :-) we
should at least document its purpose here.
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -1288,50 +1288,60 @@ private Iterator<Resource> queryAllVanityPaths(String
query) {
return it;
}
+ /**
+ * Utility class for running paged queries.
+ */
private class PagedQueryIterator implements Iterator<Resource> {
Review Comment:
would it make sense to make it a full class now (instead of an inner class)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
