joerghoh commented on code in PR #112:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/112#discussion_r1452054103
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -1163,14 +1166,17 @@ private Map<String, Map<String, Collection<String>>>
loadAliases(final ResourceR
it = queryUnpaged("alias", baseQueryString);
}
+ log.debug("alias initialization - start");
long count = 0;
long processStart = System.nanoTime();
while (it.hasNext()) {
count += 1;
loadAlias(it.next(), map);
}
long processElapsed = System.nanoTime() - processStart;
- log.debug("processed {} resources with sling:alias properties in
{}ms", count, TimeUnit.NANOSECONDS.toMillis(processElapsed));
+ long resourcePerSecond = (count * TimeUnit.SECONDS.toNanos(1) /
(processElapsed == 0 ? 1 : processElapsed));
+ log.info("alias initialization - end, processed {} resources with
sling:alias properties in {}ms (~{} resource/s)", count,
Review Comment:
same as above
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -352,7 +352,10 @@ private void execute() {
drainQueue(resourceChangeQueue);
long initElapsed = System.nanoTime() - initStart;
- log.info("vanity path initialization - end, elapsed {}ms",
TimeUnit.NANOSECONDS.toMillis(initElapsed));
+ long resourcesPerSecond = (vanityResourcesOnStartup.get() *
TimeUnit.SECONDS.toNanos(1) / (initElapsed == 0 ? 1 : initElapsed));
+ log.info(
+ "vanity path initialization - end, processed {}
resources with sling:vanityPath properties in {}ms (~{} resource/s)",
Review Comment:
instead of "end" I would prefer "completed" (IMO it's a bit more
descriptive).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
