[ 
https://issues.apache.org/jira/browse/SLING-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-6072:
---------------------------------
    Fix Version/s: Apache Sling Testing Rules 1.0.1
                   Apache Sling Testing Clients 1.0.1

> The testing rules do not call CloseableHttpClient.close()
> ---------------------------------------------------------
>
>                 Key: SLING-6072
>                 URL: https://issues.apache.org/jira/browse/SLING-6072
>             Project: Sling
>          Issue Type: Bug
>          Components: Apache Sling Testing Clients
>    Affects Versions: Apache Sling Testing Clients 1.0.0, Apache Sling Testing 
> Rules 1.0.0
>            Reporter: Konrad Windszus
>            Assignee: Andrei Dulvac
>            Priority: Major
>             Fix For: Apache Sling Testing Clients 1.0.1, Apache Sling Testing 
> Rules 1.0.1
>
>
> The rules being provided by the sling testing rules do not automatically call 
> close on the underlying {{ClosableHttpClient}} which is necessary to close 
> the dangling http connections being managed by the underlying connection 
> manager (see 
> https://hc.apache.org/httpcomponents-client-ga/tutorial/html/fundamentals.html#d5e217).
>  Even custom code cannot call close, because the underlying 
> {{ClosableHttpClient}} is not really exposed.
> I guess there is also a change necessary in testing/http/client to expose 
> such a close method as well, and also clarify under which circumstances a new 
> HttpClient is created or when an existing one is reused.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to