[ 
https://issues.apache.org/jira/browse/SLING-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125665#comment-13125665
 ] 

Bertrand Delacretaz commented on SLING-2192:
--------------------------------------------

Thanks for the updated patch, I still have a few comments:

1) Are the RequestUriOptingServlet2Test.java and RequestUriOptingServlet2 tests 
useful with your latest patch? IIUC you switched to servlet filters so they're 
probably not needed, or should be part of a separate issue.

2) The SimpleRootResourceTest of my SLING-2192-with-tests patch is missing

3) The new bundle should be at bundles/extensions/jaxrs like in that patch

4) I think we don't need the samples/slingrs, we'll create integration tests 
instead, that also act as code samples
                
> Support JAX-RS resource classes
> -------------------------------
>
>                 Key: SLING-2192
>                 URL: https://issues.apache.org/jira/browse/SLING-2192
>             Project: Sling
>          Issue Type: New Feature
>            Reporter: Reto Bachmann-Gmür
>         Attachments: SLING-2192-20110310.patch, SLING-2192-20111004.patch, 
> SLING-2192-new-jax-rs-bundle.patch, SLING-2192-new-jax-rs-bundle.patch, 
> SLING-2192-with-sling-style-style-registration.patch, 
> SLING-2192-with-tests.patch
>
>
> It should be possible to register jax resource classes and providers as 
> services. As they don't implement a specific interface services that expose 
> java.lang.Object should be considered as javx-rs services iff they have the 
> service property "javax.ws.rs" set to true.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to