stefanseifert commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-caconfig-impl/pull/9#issuecomment-2116999103
lgtm in general, some remarks: * making it configurable with default switched off is not really helpful - either we consider this caching safe then we can enable it by default - or if not, what can we do to make it safe * when may this caching be harmful? i see two use cases ** you have a long-running resource resolver e.g. in an OSGi service. this is an anti-pattern, but sometimes required e.g. if you are listing for resource change events. ** you are actually writing caconfig in your current request and reading it later (most time this is a rare use case) * maybe instead of having an OSGi configuration we should add a switch to the caconfig API where you can disable the caching if you are using caconfig in one of this use cases * more cosmetic: we should adapt the pattern to build cache keys to use separator chars which are not allowed in JCR paths and not "--" - to be on the safe side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
