kwin commented on code in PR #47:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/47#discussion_r1636650096
##########
readme.md:
##########
@@ -138,9 +147,19 @@ A typical configuration for platform applications is:
"error": false,
"warning": false
}
- }
+ },
+ "system.bundle": {}
+ },
+ "framework":{
+ "id":"org.apache.felix:org.apache.felix.framework:7.0.5"
+ },
+ "javaVersion": "21"
}
}
```
-This ensures that warnings related to the platform are not reported when the
feature is aggregated with downstream (consumer) applications. The manifests
should not be inlined under normal circumstances, since it greatly increases
the size of the resulting features.
+This ensures that
+
+- warnings related to the platform are not reported when the feature is
aggregated with downstream (consumer) applications. The manifests should not be
inlined under normal circumstances, since it greatly increases the size of the
resulting features.
+- metadata related to the system bundle is recorded at the Java 21
compatibility level
Review Comment:
Sorry, I missed the right context here. This refers to the concrete example
so is totally fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
