raducotescu commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/26#discussion_r1665870969
##########
src/main/java/org/apache/sling/scripting/sightly/impl/utils/ScriptDependencyResolver.java:
##########
@@ -154,24 +196,6 @@ public void bundleChanged(BundleEvent event) {
}
}
- private Resource getResource(@NotNull ResourceResolver resolver, @NotNull
Resource resource) {
Review Comment:
This method was there when we were still wrongly calling
`ResourceResolver#resolve` instead of `ResourceResolver#getResource`. The
latter actually does everything that this method used to do, so there's no need
to still keep it in the code.
See
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/6cfe4c3cb3a532ebfcabe13ae0028b71fb20996e/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
