rombert commented on PR #43: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/43#issuecomment-2255322404
> > at some point > > That respective code line `String::toLowerCase` line was added with [a657c91](https://github.com/apache/sling-org-apache-sling-xss/commit/a657c91ef890aaddee92d92c10506b54e536b643) in October 2022 and was included the first time in xss 2.3.0, and remained unchanged since then. > > (I added the Stream operation `distinct` to it, did not change the casing at all.) Ah, right. I was thinking about the changes that were introduced with the migration to the Java HTML Sanitiser. So we added the explicit lower-casing at that point, but I suspect that previously (in the AntiSamy days) we did lower-case attributes, so consumers were using both upper-case and lower-case attribute declarations. I think though that your change makes sense, I would be suprised to see a real-life use case where `<ol type="a">` needs to be handled differently from `<ol type="A">`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
