[
https://issues.apache.org/jira/browse/SLING-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145742#comment-13145742
]
Felix Meschberger commented on SLING-2080:
------------------------------------------
Thank you very much for providing the patch. Applied it as follows:
api: Rev. 1198758
auth/core: Rev. 1198757
auth/form: Rev. 1198771
auth/openid: Rev.1198772
jcr/jackrabbit-accessmanager: Rev.1198774
> AbstractAuthenticationHandler#sendValid states ...
Yes, changed to "explicitly"
> FormAuthenticationHandler#AuthenticationStorage:
> in this interface and its implementing class the javadoc is broken and refers
> to CookieAuthData, CookieAuthenticationHandler, CookieExtractor,
> SessionExtractor.
Fixed in Rev. 1198776
> Minor improvements to authentication [patch]
> --------------------------------------------
>
> Key: SLING-2080
> URL: https://issues.apache.org/jira/browse/SLING-2080
> Project: Sling
> Issue Type: Improvement
> Components: API, Authentication, JCR
> Affects Versions: OpenID Authentication 1.0.2, JCR Jackrabbit Access
> Manager 2.1.0, Form Based Authentication 1.0.2, Auth Core 1.0.6, API 2.2.2
> Reporter: angela
> Priority: Minor
> Attachments: SLING-2080.patch
>
>
> while having a look at the sling authentication code i fixed some javadoc
> errors, missing annotations and redundant/inconsistent code fragments that i
> came across... feel free to include the attached patch (or parts of it).
> there were two additional things i couldn't resolve:
> AbstractAuthenticationHandler#sendValid states: " // expressely tell we have
> no content but set content type"
> did you mean explicitly?
> FormAuthenticationHandler#AuthenticationStorage:
> in this interface and its implementing class the javadoc is broken and refers
> to CookieAuthData, CookieAuthenticationHandler, CookieExtractor,
> SessionExtractor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
