stefanseifert commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/41#issuecomment-2307162435
this got merged fast - i have a couple of cosmetic but relevant complaints: * the PR got merged in 3 single commits to the master branch - without any reference to the ticket number. preferred is to squash the PR when merging, and making sure that the commit message always starts with the ticket number * sonar reports a couple of open issues e.g. unused code -that should be resolved first. although there may be a lot of unresolved warnings in existing old code, we should to introduce new ones, or add annotations where the warning is not appropriate with a comment why. hopefully the approach to recreate the new collection on scratch does not come with a performance penalty for larger projects. but implementing it without that approach would require some more refactoring to support the different collection types and collection contents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
