joerghoh commented on code in PR #5:
URL:
https://github.com/apache/sling-org-apache-sling-commons-threads/pull/5#discussion_r1730395771
##########
src/main/java/org/apache/sling/commons/threads/impl/ThreadLocalCleaner.java:
##########
@@ -159,6 +164,9 @@ public void cleanup() {
diff(inheritableThreadLocalsField,
inheritableThreadLocalsCopy.references);
}
restoreOldThreadLocals();
+ if(cleanupLogCache.add(Thread.currentThread().getId())) {
Review Comment:
``Thread.getId()`` is not guaranteed to be unique, according to the javadocs
the ID can be reused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
