Hi Robert Thank you for the reply.
You are right, that's probably the most sensible course of action. I'll look into overwriting the fixupmessages instruction. Regarding parent 52, that runs into the same problem. In fact I couldn't find any parent version higher than the current one, which didn't run into this issue. I think parent 60 is fine, and we build for Java 11. That does help, thanks! Regards Julian On Wed, 18 Sept 2024 at 17:16, Robert Munteanu <[email protected]> wrote: > > Hi Julian, > > On Wed, 2024-09-18 at 15:16 +0200, Julian Sedding wrote: > > To complicate matters, there is a bnd warning "Export > > org.apache.sling.scripting.jsp.jasper.runtime, has 2, private > > references [org.apache.sling.scripting.jsp.jasper, > > org.apache.sling.scripting.jsp.jasper.el]". This warning is turned > > into an error when I update the parent and fails the build. > > This is indeed explicitly configured in more recent parent poms, but > you should be able to turn it back into a warning by overwriting the > fixupmessages instruction, I think this is what the commons-log bundle > does at [1]. > > I think that the export has been like this for a long time with no ill > effects so we don't need to touch it now. > > > Does anyone have opinions on how to proceed? Is it acceptable to bump > > the export version of "org.apache.sling.scripting.jsp.jasper.runtime" > > from 2.5.0 to 3.0.0 in order to get Java 17+ support in the build? Or > > should we leave the bundle alone and only ever build it with Java 11? > > To clarify, if you target the parent pom version 60 you need to buid > with Java 17 or newer, but the target version can still be 11. You > could also go with "just" parent pom version 52 which still builds on > 11. > > Hope this helps, > Robert > > [1]: > https://github.com/apache/sling-org-apache-sling-commons-log/blob/454190a289a568da93024bff496af773e598c97c/bnd.bnd#L33
