joerghoh commented on code in PR #17:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/17#discussion_r1796515050
##########
src/main/java/org/apache/sling/auth/core/impl/AuthenticationHandlerHolder.java:
##########
@@ -88,7 +88,7 @@ public boolean doRequestCredentials(HttpServletRequest
request,
// call handler if ok by its authentication type
if (doesRequestCredentials(request)) {
- logger.debug("doRequestCredentials: Using AuthenticationHandler
class {} to request credentials", handler);
+ this.logDebugMessage("doRequestCredentials: Using
AuthenticationHandler class {} to request credentials for request {} {}",
request);
Review Comment:
Isn't the message the same as above? In that case I would just do something
like this:
``
printDebugMessage(request);
``
and define the debug message in that method. This also eliminates the smell,
that the message (defined here) must have exactly 3 placeholders in the right
order (defined in ``logDebugMessage``).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
