[
https://issues.apache.org/jira/browse/SLING-12452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888833#comment-17888833
]
Julian Reschke edited comment on SLING-12452 at 10/12/24 8:51 AM:
------------------------------------------------------------------
[~rombert] -- can you open a JIRA ticket over in OAK?-
Both cases use "checkArgument" for which we already have OAK-11078.
was (Author: reschke):
[~rombert] - can you open a JIRA ticket over in OAK?
> Investigate removing embeding of Oak classes
> --------------------------------------------
>
> Key: SLING-12452
> URL: https://issues.apache.org/jira/browse/SLING-12452
> Project: Sling
> Issue Type: Bug
> Components: Oak
> Reporter: Robert Munteanu
> Priority: Major
> Fix For: JCR Oak Server 1.4.2
>
> Attachments: oak-server-bnd-report.txt
>
>
> The current version of the oak-server bundle currently embeds two oak classes
> {noformat}$ jar tf target/org.apache.sling.jcr.oak.server-1.4.1-SNAPSHOT.jar
> | grep -E 'jackrabbit.*class'
> org/apache/jackrabbit/oak/plugins/index/lucene/util/LuceneIndexHelper.class
> org/apache/jackrabbit/oak/plugins/index/search/util/IndexHelper.class
> {noformat}
> These classes seem to be responsible for pulling in the shaded Guava imports
> which make upgrading to new Oak version harder.
> Using {{bnd print --full
> target/org.apache.sling.jcr.oak.server-1.4.1-SNAPSHOT.jar}} I noticed the
> following usage report
> {noformat}[USEDBY]
> (...)
> org.apache.jackrabbit.guava.common.base
> org.apache.jackrabbit.oak.plugins.index.lucene.util
>
> org.apache.jackrabbit.oak.plugins.index.search.util
> org.apache.jackrabbit.guava.common.collect
> org.apache.jackrabbit.oak.plugins.index.search.util
> {noformat}
> If we could stop embedding the Oak classes the Guava imports should no longer
> be required.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
