reschke commented on code in PR #125:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/125#discussion_r1819426530
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -179,7 +188,12 @@ public MapEntries(final MapConfigurationProvider factory,
this.aliasMapsMap = new ConcurrentHashMap<>();
this.stringInterpolationProvider = stringInterpolationProvider;
+ this.conflictingAliases = new ConcurrentLinkedQueue<>();
+ this.invalidAliases = new ConcurrentLinkedQueue<>();
Review Comment:
It's likely possible but might be more intrusive, because it might affect
multiple method signatures. We already have a mix of of fields and parameters,
for instance resolveMapsMap.
MapEntries already is convoluted and really needs a refactoring...
Re concurrency: you are right, this doesn't appear to be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
