joerghoh commented on PR #61: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/61#issuecomment-2473152950
I also thought about finding it by checking the Java version, but that's another indirection for which I don't see any benefit. I would stick with the proposed change to actually check for the presence of ``java.lang.Record`` on class init and then proceed with the approach of the original implementation (via ``isAssignableFrom``). I think that this will mitigate the performance impact to some large extent. If you want to improve on top of that, feel free to create dedicated Jira tickets. And then we should also think about dedicated performance tests for this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
